Allow refreshing rates for unshipped complete orders #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
May 14, 2017
mamhoff
force-pushed
the
allow-refreshing-rates-for-unshipped-complete-orders
branch
from
72ae33a to
6ed9a78
Compare
|
Added a changelog entry as well as a spec for the intended behaviour. |
|
Just noting that previously |
|
I part from the idea that it is possible to change the line items of an order when it is completed but not shipped yet. If that is possible, then the shipments must be able to change, too, as the line items will need to be shipped somehow. |
mamhoff
force-pushed
the
allow-refreshing-rates-for-unshipped-complete-orders
branch
from
d06176f to
029aa49
Compare
|
Rebased on current master. |
|
@jhawthorn This is primarily intended to make splitting shipments for completed orders work. Right now it doesn't at all because the new shipment won't have rates. |
mamhoff
force-pushed
the
allow-refreshing-rates-for-unshipped-complete-orders
branch
from
029aa49 to
93fcf9a
Compare
houndci-bot
reviewed
Jul 7, 2017
| @@ -72,12 +72,19 @@ def ship_shipment | |||
|
|
|||
| expect(page).to have_css("#shipment_#{shipment1.id} tr.stock-item", count: 4) | |||
| shipment2 = (order.reload.shipments.to_a - [shipment1]).first | |||
| expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 1) | |||
| expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 1) | |||
When an order is complete, but not shipped yet, admins need to be able to refresh rates for a shipment. This did not work for two reasons: - `#refresh_rates` was not called on a new shipment - If it had been called, it would not have done anything. I added an expectation for a new shipment to be generated with a selected shipping rate to test this behaviour. This is a less scary change than it seems since the order updater does not refresh rates automagically anymore.
mamhoff
force-pushed
the
allow-refreshing-rates-for-unshipped-complete-orders
branch
from
93fcf9a to
9e145bd
Compare
kennyadsl
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an order is complete, but not shipped yet, admins need to be able
to refresh rates for a shipment.
This is especially the case when splitting shipments to a new location.
This will create a new shipment with no rates, and refreshing them is the
only way to get any.